Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch tracked-controls to use specific ID rather than idPrefix once browsers/SteamVR stabilize OpenVR Gamepad vs OpenVR Controllers #2371

Closed
ngokevin opened this issue Feb 9, 2017 · 5 comments

Comments

@ngokevin
Copy link
Member

ngokevin commented Feb 9, 2017

Description:

#2370

@ngokevin ngokevin added this to the 0.6.0 milestone Feb 9, 2017
@machenmusik
Copy link
Contributor

I do wonder whether there will actually be only one specific string, vs. "OpenVR Controller" "OpenVR Gamepad" "OpenVR Flight Stick" "OpenVR Tracker" -- it may be that we end up needing prefix support

@dmarcos
Copy link
Member

dmarcos commented Feb 10, 2017

Firefox is going to check the string to be consistent with Chrome

@dmarcos
Copy link
Member

dmarcos commented Feb 10, 2017

Using the string to identify controllers cannot be a long term solution. We have to come up with a better way. It might require changes in the Gamepad / WebVR APIs

@machenmusik
Copy link
Contributor

agree. may be a challenge to get consistent values across OS, as not all controllers have same ID namespaces like USB PID/VID

@ngokevin
Copy link
Member Author

ngokevin commented Apr 6, 2017

Closing for now as everything works, the prefix seems a bit more flexible. We can reevaluate strings later on.

@ngokevin ngokevin closed this as completed Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants