Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for private trakt profile #35

Closed
lluni opened this issue Apr 26, 2022 · 4 comments
Closed

Support for private trakt profile #35

lluni opened this issue Apr 26, 2022 · 4 comments

Comments

@lluni
Copy link
Contributor

lluni commented Apr 26, 2022

📝 Provide a description of the new feature

discrakt could detect if the user has manually checked-in an episode or movie and show it on Discord just like how a usual scrobble is displayed. For example when watching a movie on a DVD there is no way to scrobble it so the manual check-in function can be used instead.

➕ Additional Information

No response

@lluni
Copy link
Contributor Author

lluni commented Apr 26, 2022

Never mind, manual check-in is supported. I didn't notice it because my trakt profile is private.

The issue wasn't for this originally, but is it possible to use discrakt with a private profile?
Maybe an option could be to be able to log in to discrakt with OAuth, then it should be possible to detect scrobbles even with the profile set to private.

@lluni lluni changed the title Support for manual check-in Support for private trakt profile Apr 26, 2022
@afonsojramos
Copy link
Owner

Well, after taking a look at this it seems that it doesn't support Private profiles at all 🤷‍♂️

https://trakt.docs.apiary.io/#reference/users/watching/get-watching

@lluni
Copy link
Contributor Author

lluni commented Feb 27, 2023

Private profiles seem to be supported actually, but it requires OAuth:
image

The GET watching command also optionally supports OAuth, so that should work.

Authentication for private profile data is then done by providing an extra Authorization header containing an OAuth Bearer Token (link), which can be generated with the following endpoint: https://trakt.docs.apiary.io/#reference/authentication-oauth/get-token

@afonsojramos
Copy link
Owner

@lluni so in short this can be done manually by users who have their private profile, right? We can also build that in discrakt, and I fully support that, so feel free to open a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants