New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly defaults branch to 'master' when the default branch is set to another branch #43

Open

bobalicious opened this issue Nov 18, 2020 · 0 comments

Labels

bug

bobalicious commented Nov 18, 2020

Source repo has a default branch that is not master (e.g. main)
Button code is generated without a branch defined:

E.g.

<a href="https://githubsfdeploy.herokuapp.com">
  <img alt="Deploy to Salesforce"
       src="https://raw.githubusercontent.com/afawcett/githubsfdeploy/master/deploy.png">
</a>

On launching from the source repo, on the default branch, the 'Branch/Tag/Commit' field is empty (expected)
On attempting to deploy, the deployment fails with:
- Could not find the repository 'repo-name'. Ensure it is spelt correctly and that it is owned by 'owner-name'

In the 'From GitHub Repository' it can be seen that the URL is set to include the branch name 'master'

The text was updated successfully, but these errors were encountered:

afawcett added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment