Default Sass implementation to Dart Sass

[jbailey4]

Recently, in PR #186 support for multiple sass implementations (e.g. Dart Sass, LibSass, etc.) was added. This PR defaults the Sass implementation to Dart Sass, while adding instructions for those who want to use alternatives.

Now users can simply run: ember install ember-cli-sass

[jrjohnson]

Oh good. I was just working on this myself! Glad you beat me to it.

I was exactly at this point when I had a thought: maybe we should fully default to the JS dart sass implementation and instead of putting it into the app with addPackageToProject it should just be in the dependencies section of package.json. This would provide it by default to apps, but It would still be possible to install a different implementation if you want to and I don't think the extra NPM install will bother anyone as it wont add any weight to the final output.

I don't think it matters too much either way, but it feels to me like the sass implementation is a detail that I (as an app author) would rather hand over to this addon instead of needing to manage it myself.

[simonexmachina]

Thanks @jbailey4! Seems to be a build error...

@jrjohnson I think adding the SASS implementation as a devDependency is the right approach.

[jbailey4]

Seems to be a build error...

@aexmachina I saw this same syntax error locally and thought I pushed up the change. May need to restart the CI build

[jbailey4]

@aexmachina Tests look good now - had one node eslint issue.

[simonexmachina]

Nice!

[simonexmachina]

Published v8.0.1

[javve]

I just want to say that Dart Sass made the SCSS re-compilation 6x slower in our app with ~140 .scss files (which basically means that the overall re-compilation got 5x slower).

This project really needs a changelog so people don't miss these "breaking" changes 😅

[simonexmachina]

Good suggestion @javve. See #208.