Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tx-builder): count amount in execution cost when spend to yourself #2019

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

davidyuk
Copy link
Member

closes #2016

This PR is supported by the Æternity Foundation

Anyway the amount needs to be on balance to mine such transaction.

Anyway the amount needs to be on balance to mine such transaction.
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.34%. Comparing base (908930d) to head (5153649).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2019      +/-   ##
===========================================
+ Coverage    91.29%   91.34%   +0.05%     
===========================================
  Files          106      106              
  Lines         3502     3502              
  Branches       733      733              
===========================================
+ Hits          3197     3199       +2     
+ Misses         289      287       -2     
  Partials        16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidyuk davidyuk marked this pull request as ready for review September 13, 2024 09:35
@davidyuk davidyuk merged commit 3302b9c into develop Sep 26, 2024
5 checks passed
@davidyuk davidyuk deleted the fix-exec-cost branch September 26, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sendTransaction method is incorrectly verifying transaction amount if sending to the same address
1 participant