Extract WalletConnectorFrame, deprecate AeSdkAepp #1866
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supported by the Æternity Crypto Foundation
closes #1838, based on #1865
The idea is that different ways to connect aepp vs wallet can't have the same interface, so I think they should have their own interfaces with the ability to connect to an aepp-wide SDK instance. In the example, I'm connecting to a wallet using frame-based rpc, and a Ledger Wallet (doesn't need a connector class because it is quite simple) to the same SDK instance.
Using this approach, we can replace
with a single sdk instance and a separate logic that connects this instance to a specific wallet.