Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create top miners endpoint #1963

Open
janmichek opened this issue Oct 9, 2024 · 5 comments · Fixed by #2000
Open

Create top miners endpoint #1963

janmichek opened this issue Oct 9, 2024 · 5 comments · Fixed by #2000
Assignees

Comments

@janmichek
Copy link

  • fixed list of:
    { hash: 'ak_wM8yFU8eSETXU7VSN48HMDmevGoCMiuveQZgkPuRn1nTiRqyv', name: 'WoolyPooly' },
    { hash: 'ak_dArxCkAsk1mZB1L9CX3cdz1GDN4hN84L3Q8dMLHN4v8cU85TF', name: '2miners' },
    { hash: 'ak_9MsbDuBTtKegKpj5uSxfPwmJ4YiN6bBdtXici682DgPk8ycpM', name: '2miners.solo' },

  • fixed time window of 24h

  • blocks mined count per entry

  • reference https://www.aeknow.org/miner

  • data will be used for table and chart in aescan as in reference

Originally posted by @janmichek in #1943 (comment)

@janmichek
Copy link
Author

@yaboiishere I am afraid the result is something else that I requested.

This seems like grouped by time (day), which is not the same as 24hour window. Right?

@yaboiishere
Copy link
Contributor

Won't thss work as well? Im cautious of implementing something like that for the actual last 24 hours since that would require going over all data points and summing it up. We would prefer not doing that since if there are too many records it will result into having slow endpoints that might even timeout (an example of this is the bug that appeared in the testnet for the stats endpoint, where because of that reason it timed out).

Also we do actually know how many blocks can happen in a day for the mainnet/testnet, but implementing this would be a problem for hyperchains since there you can configure way more blocks than that, which would make the endpoint slow/unresponsive

@janmichek
Copy link
Author

janmichek commented Feb 17, 2025

Yeah, so what can I do... I am developer, not a manager. I have been waiting for over 3 months for rejecting message. Nevermind I will code it on frontend. I think its simple, just complicated to achieve with paginated response, but I will hack it somehow.

@yaboiishere
Copy link
Contributor

I've given it more thought over the weekend and I've realised that hyperchains don't have miners they have validators, so the problem I had with implementing this the way you want now should be possible without slowing down the hc. This endpoint would only be available to parent chains though (i.e. PoW ones)

@yaboiishere yaboiishere reopened this Feb 17, 2025
@janmichek
Copy link
Author

Ok, good. So when could you deliver it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants