Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show accounts and time created in genesis block #1809

Open
janmichek opened this issue Jun 13, 2024 · 7 comments
Open

Show accounts and time created in genesis block #1809

janmichek opened this issue Jun 13, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@janmichek
Copy link

Initially reported here aeternity/aescan#838 by @davidyuk

in https://aescan.io/keyblocks/0

  • it says "There is no data available", but actually, there were some accounts created
  • block mining date is incorrect

https://testnet.aeternity.io/mdw/v3/key-blocks/0
https://testnet.aeternity.io/mdw/v3/key-blocks/0/micro-blocks

@sborrazas
Copy link
Contributor

The data shown on /mdw/v3/key-blocks/0 matches the data from the node https://testnet.aeternity.io/v3/key-blocks/hash/kh_wUCideEB8aDtUaiHCtKcfywU6oHZW6gnyci8Mw6S1RSTCnCRu

Plus, that key block does not have any microblocks, you can tell because the next key-block has as "previous_block" the first key-block, so there are no micro blocks in between: https://testnet.aeternity.io/mdw/v3/key-blocks/1 (prev_hash == kh_wUCideEB8aDtUaiHCtKcfywU6oHZW6gnyci8Mw6S1RSTCnCRu)

@sborrazas sborrazas self-assigned this Jun 24, 2024
@davidyuk
Copy link
Member

I think the node won't expose it in a public api the same as other activities with no transaction. Currently, mdw exposes activities by account. In this case, it would be useful to have activities per block, which should include initial coin distribution in the genesis block.

@sborrazas
Copy link
Contributor

I thought this was about /key-blocks and /micro-blocks endpoints returning the wrong data. If that wasn't what was intended please close the issue and open up a new one to add a feature to retrieve initial coin distribution in genesis blocks

@davidyuk
Copy link
Member

Why do you need a separate issue for this?

@sborrazas
Copy link
Contributor

This issue was about /key-blocks endpoint displaying the wrong data and missing micro-blocks. This wasn't the case, we can close it

@davidyuk
Copy link
Member

Jan just showed the endpoint he uses, the main problem is that mdw is not exposing accounts created in the genesis block as stated in the title.

@sborrazas
Copy link
Contributor

The /key-blocks endpoint does not expose the genesis accounts, but we can add a new endpoint that does. This is a new feature request

@sborrazas sborrazas added the enhancement New feature or request label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants