Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully skip nightly releases when credentials aren't present #954

Closed
hectormz opened this issue May 10, 2022 · 3 comments · Fixed by #983
Closed

Gracefully skip nightly releases when credentials aren't present #954

hectormz opened this issue May 10, 2022 · 3 comments · Fixed by #983
Labels
CI Involves continuous integration enhancement New feature or request help wanted Extra attention is needed

Comments

@hectormz
Copy link
Contributor

Description of your problem or feature request

My main branch of my fork of aesara runs a nightly build via GitHub Actions, and fails each night because I don't have the secrets/credentials. I get a notification of the failed Action every night, and assume this happens for others too.

Can we change the GitHub Action to disable this? I think two options would be to either skip the build if the secret credentials are not found, or to check if it is run on the main aesara-devs copy.

@brandonwillard
Copy link
Member

Actions can be disabled at the repo level; this is what I've done for mine.

Aside from that, small updates to the Actions workflow that help with this are welcome.

@hectormz
Copy link
Contributor Author

TIL individual workflows can be disabled!

Up to you if you want to consider any of the changes to the workflows.

@brandonwillard brandonwillard changed the title Skip Nightly Release on forked aesara Gracefully skip nightly releases when credentials aren't present May 10, 2022
@brandonwillard brandonwillard added enhancement New feature or request help wanted Extra attention is needed CI Involves continuous integration labels May 10, 2022
@hectormz
Copy link
Contributor Author

Perhaps the easiest thing would be:

jobs:
  build_and_publish:
    name: Build source distribution
    if: github.repository == 'aesara-devs/aesara'
    runs-on: ubuntu-latest

That way it will still fail if something happens to the org secrets. And building nightly and pushing to Pypi should only come from this account anyway.

I just tested this on my main with a "Nightly" action that runs on push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Involves continuous integration enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants