Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge RandomVariable Ops #66

Closed
brandonwillard opened this issue Oct 1, 2020 · 2 comments · Fixed by #137
Closed

Merge RandomVariable Ops #66

brandonwillard opened this issue Oct 1, 2020 · 2 comments · Fixed by #137
Assignees
@brandonwillard
Labels
enhancement New feature or request

Comments

@brandonwillard
Copy link
Member

The Symbolic PyMC project contains a base RandomVariable Op with advanced shape-handling logic and a more optimization-friendly form, as well as implementations for many common random variable types. We should merge/replace the current RandomFunction Op with RandomVariable (and the related [rng_mrg](https://github.com/pymc-devs/Theano-PyMC/blob/master/theano/sandbox/rng_mrg.py implementations).

There's also RandomStreams class that should be considered/made to work with RandomVariable.
@brandonwillard brandonwillard added enhancement New feature or request new operator labels Oct 1, 2020
@twiecki
Copy link
Contributor

twiecki commented Oct 2, 2020

This would be an incredible mile-stone to hit.

@michaelosthege
Copy link
Contributor

Was this closed by #131 or #137 ?

@brandonwillard brandonwillard linked a pull request Dec 15, 2020 that will close this issue
Add new RandomVariable Op and optimizations #137
Merged
4 tasks
@brandonwillard brandonwillard self-assigned this Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandonwillard brandonwillard

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new RandomVariable Op and optimizations brandonwillard/aesara
3 participants
@twiecki @brandonwillard @michaelosthege