Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making AsciiSequenceView not final #242

Closed
RichardWarburton opened this issue Aug 20, 2021 · 0 comments
Closed

Making AsciiSequenceView not final #242

RichardWarburton opened this issue Aug 20, 2021 · 0 comments

Comments

@RichardWarburton
Copy link
Contributor

In a javadoc improvement commit (d6322f7) AsciiSequenceView was made final. We make use of that class in Artio and it looks like some users have subclassed it, making Agrona 1.10 an incompatible upgrade for them. Would there be any objection to allowing subclassing on that class again?

I've poked the user on their motivation here, but the thing is that because AsciiSequenceView instances can relate to fields with FIX messages I think that if you want to have a field with some extra validation of logic on it and not pay an additional indirection price from composing your field class with an AsciiSequenceView then sub-classing seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants