Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress/57 #192

Merged
merged 5 commits into from
May 2, 2023
Merged

Progress/57 #192

merged 5 commits into from
May 2, 2023

Conversation

aerispaha
Copy link
Member

@aerispaha aerispaha commented May 2, 2023

Add coverage to swmmio.inp API for the follow sections:

  • DIVIDERS
  • LOSSES
  • AQUIFERS
  • GROUNDWATER

Makes progress on #57

@@ -751,6 +755,23 @@ def evaporation(self, df):
"""Set inp.evaporation DataFrame."""
self._evaporation_df = df

@property
def losses(self):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure we could abstract away this repetitive logic - at least for the most trivial cases

@aerispaha aerispaha marked this pull request as ready for review May 2, 2023 18:04
@aerispaha aerispaha merged commit ef24aca into master May 2, 2023
@aerispaha aerispaha deleted the progress/57 branch May 2, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant