Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUTHORS #183

Merged
merged 2 commits into from
Apr 27, 2023
Merged

AUTHORS #183

merged 2 commits into from
Apr 27, 2023

Conversation

bemcdonnell
Copy link
Member

No description provided.

@aerispaha
Copy link
Member

Hey @bemcdonnell! I just added an AUTHORS file, and a script to generate this file automatically, closely following the pattern over in this other open source package called pyswmm. Have you ever heard of it??

Anyway, let me know if this is what you had in mind for this PR. If so, I'm cool with merging this into master.

bemcdonnell
bemcdonnell commented Apr 27, 2023
View reviewed changes
Copy link
Member Author

@bemcdonnell bemcdonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think we use the auto author script anymore but that’s all good! And I’ve heard I’d pyswmm 😊

@aerispaha aerispaha marked this pull request as ready for review April 27, 2023 21:02
@aerispaha aerispaha merged commit c373407 into master Apr 27, 2023
@aerispaha aerispaha deleted the add_authors branch April 27, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bemcdonnell @aerispaha