Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define max_columns option as a display option #127

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

stijnvanhoey
Copy link
Contributor

To overcome issue pandas._config.config.OptionError: 'Pattern matched multiple keys' in pandas 1.4.0, one need to specify display of render when defining the option.

To overcome issue `pandas._config.config.OptionError: 'Pattern matched multiple keys'` in pandas 1.4.0, one need to specify display of render when defining the option.
@aerispaha aerispaha self-requested a review February 9, 2022 17:47
@aerispaha
Copy link
Member

Hi @stijnvanhoey, thanks for this patch! I wonder if we even need to do this Pandas display.max_columns configuration. It seems like it might be a better idea to let the users manipulate any Pandas display options in their own environment.

Regardless, I'm okay with this change. I just want to see why the documentation build is failing before merging these changes.

@stijnvanhoey
Copy link
Contributor Author

Thanks, it was only a very small fix :-)

if we even need to do this Pandas display.max_columns configuration. It seems like it might be a better idea to let the users manipulate any Pandas display options in their own environment.

I do agree.

With respect to the documentation bug, seems that one need to specify the exact version of mistune in the doc requirements (version 2 removed the BlockGrammar).

@aerispaha aerispaha merged commit edf5426 into pyswmm:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants