Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model.subcatchments fails to merge rpt data when subcatchments have numeric names #106

Closed
aerispaha opened this issue Oct 2, 2020 · 0 comments · Fixed by #107
Closed

model.subcatchments fails to merge rpt data when subcatchments have numeric names #106

aerispaha opened this issue Oct 2, 2020 · 0 comments · Fixed by #107
Assignees
@aerispaha
Labels
bug complete
Milestone
v0.4.6

Comments

@aerispaha
Copy link
Member

aerispaha commented Oct 2, 2020 •
edited
Loading

Subcatchments (and probably other elements) are not properly merging together with RPT data when they have numeric names.

from swmmio.tests.data import MODEL_EX_1
model = swmmio.Model(MODEL_EX_1)
subs = model.subcatchments.dataframe

Here, subs will NaN values in the rpt-derived columns because the rpt parsing does not cast indices as strings before joining with inp dataframes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aerispaha aerispaha

Labels
bug complete
Projects
None yet
Milestone
v0.4.6
Development

Successfully merging a pull request may close this issue.

cast indices of dataframes to strings in lower-level functions pyswmm/swmmio
1 participant
@aerispaha