-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tasks Improvements #9
Open
jonpugh
wants to merge
66
commits into
7.x-3.x
Choose a base branch
from
2212149-tasks-refresh-config
base: 7.x-3.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld drupal_add_js() calls
…ld drupal_add_js() calls
…ect/hosting into 11494427-hosting-task-js-remove
…ting Vue.js. - Rewrite hosting_task.js to follow Drupal.behaviours pattern and to implement Vue.js app. - Return JSON results via hosting/tasks/queue hosting_task_ajax_queue() menu callback. - Add views template for hosting-task-list tables to allow embedding of Vue.js markup. - Add hostingTasks javascript settings and vue.js to View hosting_task_list-block.
…ting Vue.js. - Add a views_post_execute hook to alter task data. - Wrap TR in template so we can apply class to TR.
…ting Vue.js. - Adding "View" button to task logs.
…ting Vue.js. - Renaming table views template to only affect the block.
…ting Vue.js. - Renaming table views template to only affect the block.
…ting Vue.js. - Removing unused experimental vue.js class binding.
…ting Vue.js. - Creating a custom theme function/template for available tasks table. - Moving hosting task settings to hook_prepreprocess_page() so it loads on every page. Load available tasks on pages node pages. - Combining tasks and available tasks in a single payload. - Adding vue model for available tasks.
…ting Vue.js. - Fixing link to task logs.
…ting Vue.js. - Add a watch function to allow for attachingBehaviors
…ting Vue.js. - Only show view link if there is a task nid.
…ting Vue.js. - Hide tasks if they are not permitted and they have no task NID. - Add "disabled" buttons. - Hide the entire row if the task is "hidden".
…-tasks-refresh-config
…ting Vue.js. - Adding content type to Hosting Task View and template so it reads "Verify Site:" instead of "Verify". - Adding jQuery "timeago" plugin and adding timestamps so we can dynamically update "time ago". See http://timeago.yarp.com/ - Styling "time ago" text to not be too obtrusive.
…-tasks-refresh-config
…tput if javascript is disabled.
…ithout Javascript.
…s come it. This ensures new tasks restart at "0 seconds".
…e type. Adding a helper function hosting_task_type_name() to get a readable name from a task type.
…ame from a task type.
…epending on the reference node.
…to add node type to the view.
…jects: Verify Site, Verify Platform, Verify Server.
…-tasks-refresh-config
- Added update to enabling timeago module and save date format. - Added hook hook_date_format_types() to enable a "Dynamic Time Ago" format. - Exporting the hosting_task_list view to use the Dynamic Time Ago format.
…-tasks-refresh-config
…re variables for executed and delta.
…her so it clears immediately.
…ps Drupal.behaviors in order to uncomplicate things. All logic can be contained in the Vue object. Also, commenting out our timeago code in order to use the drupal modules settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using for review. May not ever merge this.