Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center Play Button #3453

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Center Play Button #3453

merged 3 commits into from
Sep 25, 2024

Conversation

glorenzen
Copy link
Contributor

This is a UI fix to adjust the playback controls so that the chapter name and play button are centered on the screen.

I moved the playback rate controls over to the right with the volume and other icons. The icons might get a little crowded on very small mobile screens (below 400px wide), but it seems okay from my testing.

image

This fixes #3244

@nichwall
Copy link
Contributor

Looks good to me! I do like the player speed on the right now that I'm seeing that.

Not for this PR, but maybe we want to expand the player settings (right-most button) to be an "enable/disable" for each of the buttons on the right, such as if somebody never uses bookmarks or adjusting the volume in the player, they can hide those buttons? That would help address the crowding on smaller screens.
There are some initial plans to transition to a newer framework for the web client, but I don't know when or what that will be so not sure if moving the buttons into the menu is worth the time if it is non-trivial.

@advplyr
Copy link
Owner

advplyr commented Sep 25, 2024

There are some initial plans to transition to a newer framework for the web client, but I don't know when or what that will be so not sure if moving the buttons into the menu is worth the time if it is non-trivial.

Yeah I'm not sure about this. At this point it seems like whatever we build in Nuxt is going to have to be re-written in whatever we switch to next.

This PR looks good. I had one hesitation on putting the speed there which is that the volume bar overlaps it. This happened a few times while testing where I went to click the playback speed but my cursor went over the volume so I had to move it off. Could just be me.

I took the time to get rid of the mono font used for playback speed that has bothered me for a while

thanks!

@advplyr advplyr merged commit 48bbf0d into advplyr:master Sep 25, 2024
5 checks passed
@glorenzen glorenzen deleted the center-play-button branch October 14, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: centre the play button
3 participants