Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Series and series-part do not get embedded when you write meta data to files. #3547

Closed
derkington opened this issue Oct 23, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@derkington
Copy link

What happened?

Previously I would manually update my audio files with information including the series information using mp3tag (extended fields for series information). The audiobookshelf app would then enable me to click on series in the interface and see all the books which are part of the series. I have recently started using the audiobookshelf user interface to match files and embed the data into the files for the first time. It appears that the series and book number is identified when a match is carried out in the UI, however the series and series part does not get written to the file or display in the UI. When I add and populate the series and series part using mp3tag and do a scan everything displays and works as expected.

What did you expect to happen?

The series information would appear in the android app, allowing me to see all books in the series.

Steps to reproduce the issue

  1. Match a audiobook that is part of a series
  2. The series field does not appear in the android app.

Audiobookshelf version

v2.15.1

How are you running audiobookshelf?

Debian/PPA

What OS is your Audiobookshelf server hosted from?

Linux

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Firefox

Logs

No response

Additional Notes

No response

@derkington derkington added the bug Something isn't working label Oct 23, 2024
@mikiher
Copy link
Contributor

mikiher commented Oct 27, 2024

Let me make sure I understand the sequence of actions you're reporting.

  1. You matched a book (did you use Quick Match or the Match tab in the book details box?)
  2. The match contained a series and sequence number
  3. If you used the Match tab, you submitted the match by selecting it and clicking the Submit button on the bottom?
  4. Now that book doesn't have the matched series in the Audiobookshelf android app?

Did I understand the sequence correctly?

@advplyr
Copy link
Owner

advplyr commented Oct 27, 2024

I believe the old tone metadata embed tool would embed series and series-part meta tags in a way they were accessible to ffprobe from both mp3 and mp4 containers.
I'm not sure how it works but tone set up special meta tags that made it accessible for non-mp3.
server/utils/toneHelpers.js

Now for mp4 containers unless they are embedded in that way ffprobe won't pull a series and series-part tag.

Since we switched to ffmpeg for embedding we use the grouping tag which is available on mp3 and mp4 containers. Last week I updated the grouping tag to use a semicolon delimited list of series + sequence in order to fix a bug with parsing multiple series. See #3473 and the fix 953ffe8

This was one of the downsides to switching to ffmpeg for embedding meta tags. Ffprobe only supports a small number of tags for mp4 containers.

The docs should be updated once the next release goes out showing which tags can be read in which container and which tags get written when embedding.

@mikiher
Copy link
Contributor

mikiher commented Oct 28, 2024

I know the bug title is about embedding, however that is not what the bug description says. It says:

It appears that the series and book number is identified when a match is carried out in the UI, however the series and series part does not get written to the file or display in the UI.

It also says how to reproduce it:

Match a audiobook that is part of a series
The series field does not appear in the android app.

I was not able to reproduce the described behavior, hence the clarifying questions asked.

@derkington
Copy link
Author

derkington commented Nov 1, 2024

Sorry that this was not clear. I have added some pictures to show the outcome I was expecting instead.
I do a match, see series info is present. Go the phone app and series is not present for the book, but series info is in the subtitle. I get mp3tag and add series and series-part tags, the phone app now shows series (3rd image). I click on series and all the books of the series are displayed.

After matching and ultimatly embedding I was hoping for the book to be populated with the info in image 3, instead you end up with image 2 unless you add further info and save which I use mp3tag to do.

1 Match
2 After match abd embed
3 after adding series tags to file

@mikiher
Copy link
Contributor

mikiher commented Nov 1, 2024

Thanks for the exaplanation. This is very weird. I also see that the matched Narrators are not reflected in image 2, not only the Series.

A couple of followup questions:

  1. Are you sure you pressed the Submit button on the bottom of the Match tab in image 1? You have to scroll down to the bottom to see it.
  2. After you pressed Submit, can you please take a screenshot of the Details tab and share it here?

@advplyr
Copy link
Owner

advplyr commented Nov 21, 2024

Is this still an issue?

@advplyr advplyr added waiting Waiting for OP unable to reproduce Issue is not yet reproducible labels Nov 21, 2024
@advplyr advplyr closed this as not planned Won't fix, can't repro, duplicate, stale Dec 1, 2024
@advplyr advplyr removed waiting Waiting for OP unable to reproduce Issue is not yet reproducible labels Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants