Received bad header from gateway when you have tons of remote subnets

[m33m33]

Hi

It seems you get the "Received bad header from gateway" error when your vpn server has tons of routes to remote subnets to push to the client.

I have narrowed the issue down to a hardcoded buffer size.

Here is the log, and a generous size increase of the buffer size... is it safe ?

It looks good - works well here at least.

openfortivpn.log

[DimitriPapadopoulos]

Strange, I would have expected at least a warning such as Response too big:

openfortivpn/src/http.c

Lines 209 to 210 in f7110c4

	if (bytes_read == BUFSZ - 1) {
	log_warn("Response too big\n");

Anyway, thank you for reporting this!

In the short term I don't know if there's some magic buffer size that would be guaranteed to fit all. In any case a BUFSZ value of 0x10000 would use 64 KB, which shouldn't be a problem nowadays on any decent computer.
In the long term, we might need to change for a solution based on realloc() or use an existing external library as already suggested for XML or HTTP parsing.