Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid ifndef statements #253

Closed
mrbaseman opened this issue Feb 19, 2018 · 2 comments
Closed

avoid ifndef statements #253

mrbaseman opened this issue Feb 19, 2018 · 2 comments

Comments

@mrbaseman
Copy link
Collaborator

in #250 it was noticed that probably the whole issue was opened based on a misunderstanding.
The #ifndef __APPLE__ statements are confusing and should be replaced by #ifdef __APPLE__ accompanied by the appropriate code-reordering

I have opened this issue as a reminder for myself. I'm going to address this, probably after my next vacation...
@mrbaseman mrbaseman mentioned this issue Feb 20, 2018
Merged
@DimitriPapadopoulos
Copy link
Collaborator

Hasn't this issue been solved by 84b92ac?

@mrbaseman
Copy link
Collaborator Author

sure, I just forgot to close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DimitriPapadopoulos @mrbaseman