Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runs as root by default #9

Open
nigel-gott opened this issue Apr 12, 2021 · 2 comments
Open

Runs as root by default #9

nigel-gott opened this issue Apr 12, 2021 · 2 comments

Comments

@nigel-gott
Copy link

Hi, currently I believe mjml-server's image runs as root by default which is not desirable. The base image (node) used has a page with best practices showing how instead it could run as the node user which is more secure:
https://github.com/nodejs/docker-node/blob/main/docs/BestPractices.md#non-root-user
What do you think about making this change in mjml-server also?

@adrianrudnik
Copy link
Owner

Hi there, yes I want to move it to a non-root user soon, through it will introduce a BC break because the default listening port will change from 80 to 8080 as I can no longer use the privileged port.

@mmulqueen
Copy link

If anyone comes across this, here are the basic modifications needed to run as non-root DigitalGrads@1c33bc7 (listens on port 8080)

I won't submit a pull request because as @adrianrudnik states, it's a breaking change.

P.S. Thanks for making this Docker image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants