Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding of Azure china appinsights to the listener so that we can link it up with that #21

Closed
venkatkriish opened this issue Jun 22, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@venkatkriish
Copy link

Hi Team,
We are trying to use azure china appinsights for the jmeter backend listeners to have a dashboard to appinsights.

we are facing issue that it cannot reached out the appinsights even though we have given the correct instrumentation key

Can we have a enhansement for this to work on this issue i found a nice document over here from microsoft

https://docs.microsoft.com/en-us/dotnet/api/microsoft.applicationinsights.extensibility.telemetryconfiguration.-ctor?view=azure-dotnet#Microsoft_ApplicationInsights_Extensibility_TelemetryConfiguration__ctor_System_String_Microsoft_ApplicationInsights_Channel_ITelemetryChannel_

Thanks,
Venkatesh.K

@adrianmo
Copy link
Owner

Hi @venkatkriish,

Thanks for your feedback! I believe you are not getting any data into your App Insights because the endpoint configuration is not targeting Azure China. I haven't thought about it before, but it makes sense that you should be allowed to override the default App Insights endpoint and target Azure China or Azure Government.

I'll work on a fix for this and create a PR with the changes. I'll ask you to try out the JAR file to validate the changes because I don't have access to either Azure China or Azure Gov.

Thank you!

@adrianmo adrianmo added the enhancement New feature or request label Jun 22, 2021
@adrianmo
Copy link
Owner

adrianmo commented Jun 22, 2021

@venkatkriish I've published a pre-released that I want you to test.

Download the JAR for version 0.2.6-rc0 from here: https://github.com/adrianmo/jmeter-backend-azure/releases/tag/0.2.6-rc0

Then instead of using the "instrumentationKey" in the plugin configuration table, use "connectionString" with the value of your App Insights connection string, which should include the Azure China endpoint. It can be found in the overview tab, below the instrumentation key.

image

Please let me know if it works. If it does, I'll publish a new version of the plugin.

@venkatkriish
Copy link
Author

venkatkriish commented Jun 23, 2021

Hi @adrianmo,

Thanks for the above enhancement we are testing it out with the above release jar file.
i will let you know once we have done with the testing
This was really appreciate with your enhancement.

Thanks.

@venkatkriish
Copy link
Author

Closing this issue as w are able to get the metrics in azure china as well.

@adrianmo
Copy link
Owner

Thanks for testing this - 0.2.6 is now released and available from Maven Central 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants