Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HessianTracer type improvements #40

Closed
gdalle opened this issue May 3, 2024 · 2 comments · Fixed by #53
Closed

HessianTracer type improvements #40

gdalle opened this issue May 3, 2024 · 2 comments · Fixed by #53

Comments

@gdalle
Copy link
Collaborator

gdalle commented May 3, 2024

struct HessianTracer{S} <: AbstractTracer
inputs::Dict{UInt64,S}
end

Would it be more coherent to have keys of type eltype(S), since they are also indices, rather than always UInt64?

@adrhill
Copy link
Owner

adrhill commented May 3, 2024

Sounds good. :)

@gdalle gdalle changed the title Type of keys in HessianTracer HessianTracer type improvements May 6, 2024
@gdalle
Copy link
Collaborator Author

gdalle commented May 6, 2024

As seen in #45, we should also

  • make the AbstractDict subtype parametric, e.g. to use SortedDict in conjunction with SortedVector
  • rename the type parameter T to I for integer wherever it still appears
  • add an inner constructor that checks eltype(S) == I

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants