Draft: Add daily goals funcionality #331
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP Issues: - After setting the time for a label, opening the dialog keeps the old time value. Only updates when the view is closed & re-opened. Probably caused by how the dialog is created (a lambda), causing the default value to be set only on creation of the view. - The set time doesn't show up anywhere
|
Thank you for your contribution but please keep in mind that I'm working on a new version of the app(from scratch) and I won't be able to use your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Adrian.
As an exercise in Android Development, I have decided to attempt extending your application with a "Daily goal" functionality.
TODO:
Daily goalin SettingsDaily goalin Labels EditorDaily goalin main application viewDaily goaltarget in Statistics, as a line in time history. To view how we were doing in completing daily goals over time.It is my first time contributing to a foreign Android project, so any guidance as to what I might be doing incorrectly, is greatly appreciated. Especially because the project is so old, extensive and polished.
Example design of Main Activity Preview
