Add externallyLoaded option to context, and load those separately #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, this is strnage, and has nothing to do with my changes, any ideas? |
|
This seems to "solve" the problem, which apparently happens only on node 10 because it's faster :) As i am no redis expert by any means, does those changes make sense? |
|
Now i really don't get it... @adrai any ideas? |
|
Can you revert the redis changes (must be a node 10 problem, will look at it later) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds an externallyLoaded option to the context definition. Basically, this means that the user ( or more likely a library ) provides the structureLoader with an already defined context object which can be used directly ( a context object to which aggregates are added, to which commands are added and so on ).
This allows writing alternative/additional loaders, who can output the result in ready to use for this library. This will allow requests like this one and this one achieved fairly easy according to other logic/structure without breaking the existing logic/definitions.
This whole is done as are in a process of writing an on-top addition/library allowing a one-file aggregate definitions similar to other CQRS implementations.