Business rule fail doesnt cause save to cancel

[ssolbak]

This code looks great. I've spent the day digging into it but do have a couple issues:

I took an exact copy of the sample and changed itemBusinessRules as follows in the code below. All I did was add a rule that you cant add text that already exists.

Also according to other people, debugging with WebStorm seems to break the functionality. Has anyone else solved this? Its a real pain to not have debugging.

Thanks,
Sean

PS I added the code to init the repository in the domain server.js
PSS I took Udis course a couple years ago. Is the idea to have a separate node instance per AC or is it ok to have multiple aggregates in the same application. I only really have one component that I need to scale like crazy and am ok having the rest on the same node.

var repository = require('viewmodel').read
, itemRepo = repository.extend({collectionName: 'item'});

module.exports = {
itemAggregate: [

function checkForError(changed, previous, events, callback) {

  itemRepo.find({text: changed.text}, function(err, items) {
    if (err){
      //todo
    }

    console.log("There are " + items.length + " items with text= " + changed.text);

    if(items.length > 0){
      return callback('cannot use existing text');
    }
  });

  if (changed.text.toLowerCase().indexOf('error') >= 0) {
    return callback('This is just a sample rule!');
  }

  callback(null);
}

]
};

[adrai]

Can you try with forkEventDispatching = false ?

[ssolbak]

forkEventDispatching = false fixes the debugging issues thanks!

I did nothing but edit server.js to mongoDb on the host and the server.js modifications are below. I have the latest of all the npm modules. I am developing on a windows box using WebStorm.

var repository = require('viewmodel').read;

var options = {
commandHandlersPath: __dirname + '/commandHandlers',
aggregatesPath: __dirname + '/aggregates',
sagaHandlersPath: __dirname + '/sagaHandlers',
sagasPath: __dirname + '/sagas',
forkEventDispatching: false,
eventStore: {
type: 'mongoDb', //'mongoDb',
dbName: 'tmptest'
},
commandQueue: {
type: 'mongoDb', //'mongoDb',
dbName: 'tmptest'
},
repository: {
type: 'mongoDb', //'mongoDb',
dbName: 'tmptest'
}
};

repository.init(options.repository, function(err) {
console.log("initializing repository done");
});

[ssolbak]

Just to clarify (it was a bit confusing) the forkEventDispatching = false fixed the debugging issue but the business rule issue is still outstanding. Even though the business rule doesnt pass, the save still occurs.

S

[adrai]

In the next few days I hope to look at it... sorry... I'm under pressure at the moment... :-(

[ssolbak]

No worries :) Just re-read my post and I was a little unclear. I'll take a look this weekend as well.

[adrai]

ok try with latest release v0.5.3

[ssolbak]

I get the following error... "Error: Callback was already called."

[adrai]

Please check if you call the callback twice in the business rule... If it's like the above code snipped it will call it twice...

[ssolbak]

Oops ya sorry my bad. The fix is good!