Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command revision verifying while disabled persistance #112

Closed
repkins opened this issue Nov 28, 2017 · 3 comments
Closed

Command revision verifying while disabled persistance #112

repkins opened this issue Nov 28, 2017 · 3 comments

Comments

@repkins
Copy link
Contributor

repkins commented Nov 28, 2017

Hello, @adrai!

I have noticed a potential bug about how default command handler verifies command revision with associated aggregate. While aggregate has disabled persistence using definition property disablePersistence: true, I don't think it should verify revision of incoming command with such aggregate because there is no stored previous events to build aggregate from them so far.
@adrai
Copy link
Contributor

adrai commented Nov 28, 2017

So would you suggest to not verify the revision when disablePersistence is set to true, right?

adrai added a commit that referenced this issue Nov 28, 2017
@adrai
#112 do not verify the revision when disablePersistence is set to true
7642b14
@adrai
Copy link
Contributor

adrai commented Nov 28, 2017

v2.9.8

@repkins
Copy link
Contributor Author

repkins commented Nov 28, 2017

Yap, i would suggest. :-)

@adrai adrai closed this as completed Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adrai @repkins