Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #92 enable jdkRepo #103

Closed
wants to merge 1 commit into from
Closed

Conversation

bhuva-v
Copy link

@bhuva-v bhuva-v commented Oct 1, 2021

fixes #92

@sophia-guo
Copy link
Contributor

The environment variable is JDK_REPO and JDK_BRANCH

Copy link
Contributor

@sophia-guo sophia-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophia-guo
Copy link
Contributor

We will also need to update README. I will create a separate issue.

@sophia-guo
Copy link
Contributor

@bhuva-v could you resolve the conflicts and commit again? #102 was merged hence you commit got the conflicts. Thanks.

@smlambert
Copy link
Contributor

PR needs conflicts resolved @bhuva-v are you able to do that, if that is not possible, let's close this PR.

FYI @sophia-guo

@karianna
Copy link
Contributor

@bhuva-v & @sophia-guo - Bump :-)

@sophia-guo sophia-guo closed this Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to support jdk repo and branch
4 participants