Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releaseCheck: fix non-POSIX syntax for Alpine #146

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented Jan 23, 2024

Removes bash-specific syntax.

Unlike me to make this sort of error as I'm generally quite picky about it :-) The problem didn't show up on my development Fedora system but has an issue on Linux systems using dash by default.

Fixes #145
Also referred to in adoptium/temurin#13 (comment)

@sxa sxa self-assigned this Jan 23, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@sxa sxa force-pushed the fix_alpine_syntax branch 2 times, most recently from c553abc to 579fd25 Compare January 23, 2024 10:14
@sxa sxa force-pushed the fix_alpine_syntax branch from 579fd25 to 8838633 Compare January 23, 2024 10:38
@sxa
Copy link
Member Author

sxa commented Jan 23, 2024

/merge

Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@jerboaa
Copy link
Contributor

jerboaa commented Jan 23, 2024

/approve

1 similar comment
@gdams
Copy link
Member

gdams commented Jan 23, 2024

/approve

@github-actions github-actions bot dismissed their stale review January 23, 2024 11:05

Thank you @jerboaa and @gdams for your approvals, this pull request is now approved to merge during release.

@sxa sxa enabled auto-merge (squash) January 23, 2024 12:16
@sxa
Copy link
Member Author

sxa commented Jan 23, 2024

@jerboaa Can you do a "normal" approval on the PR too please as it needs a second to allow me to merge.

Never mind - thanks @tellison !

@sxa sxa merged commit 6a4d3da into adoptium:master Jan 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax error in releaseCheck.sh
4 participants