Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 32bit: HelpFlagsTest fails due to missing specifications #2840

Closed
adamfarley opened this issue Aug 31, 2021 · 3 comments
Closed

Windows 32bit: HelpFlagsTest fails due to missing specifications #2840

adamfarley opened this issue Aug 31, 2021 · 3 comments

Comments

@adamfarley
Copy link
Contributor

adamfarley commented Aug 31, 2021

Describe the bug
OpenJDK Test tools/launcher/HelpFlagsTest.java fails on Windows 32bit, JDK11 and JDK16, due to an apparent test config issue.

JDK11: https://ci.adoptopenjdk.net/job/Test_openjdk11_hs_extended.openjdk_x86-32_windows_testList_0/10/console
JDK16: https://ci.adoptopenjdk.net/job/Test_openjdk16_hs_extended.openjdk_x86-32_windows_testList_0/7/consoleFull

Earlier reference.

To Reproduce
Grinder link

Expected behavior
I expect the test to pass, as it does on Windows 64bit.

Screenshots

23:47:39  STDERR:
23:47:39  java.lang.AssertionError: HelpFlagsTest failed:
23:47:39  Tool jaccessinspector-32.exe not covered by this test. Add specification to jdkTools array!
23:47:39  Tool jaccesswalker-32.exe not covered by this test. Add specification to jdkTools array!
23:47:39  
23:47:39  	at HelpFlagsTest.main(HelpFlagsTest.java:378)
23:47:39  	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
23:47:39  	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
23:47:39  	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
23:47:39  	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
23:47:39  	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:298)
23:47:39  	at java.base/java.lang.Thread.run(Thread.java:829)
23:47:39  
23:47:39  JavaTest Message: Test threw exception: java.lang.AssertionError
23:47:39  JavaTest Message: shutting down test

Additional context
Test will be excluded. Link.

@smlambert
Copy link
Contributor

I am presuming the jdkTools array is in upstream code, in which case this issue should get reported and fixed upstream.

@adamfarley
Copy link
Contributor Author

adamfarley commented Sep 1, 2021

Issue reported here: https://bugs.openjdk.java.net/browse/JDK-8273235

Seems a simple enough fix now I've read the code. Have added notes on the fix to that bug.

AF:23/11 - Approved and merged into jdk17. Approved for jdk11u-dev, and now awaiting sponsorship.

AF:24/11 - Merged into jdk11u-dev. Already found its way into jdk11u. Unexcluding the test.

#3149

@smlambert
Copy link
Contributor

Closed now that #3149 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants