Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about Wormhole #214

Closed
alexlafroscia opened this issue Nov 12, 2015 · 5 comments
Closed

Add note about Wormhole #214

alexlafroscia opened this issue Nov 12, 2015 · 5 comments

Comments

@alexlafroscia
Copy link
Member

Using Ember Paper for the first time in a while, it seems like it's improved a ton! One thing I noticed though; you need to add the Wormhole outlet to your application.hbs file, as such:

<div id="paper-wormhole"></div>

However, this doesn't seem to be mentioned anywhere. If it's not, could this be added to the Readme?

@miguelcobain
Copy link
Collaborator

@alexlafroscia That is correct.

I'd rather make the addon add that automatically using the contentFor hooks.
Similar to this: https://github.com/cibernox/ember-basic-dropdown/blob/master/index.js#L8

@alexlafroscia
Copy link
Member Author

Oh, does that work? I'd be happy to make a PR to add that in; I absolutely agree that that's a better approach.

@miguelcobain
Copy link
Collaborator

I'd be very happy to accept such a PR. :)

@alexlafroscia
Copy link
Member Author

Sweet, I'll put something together tonight/tomorrow.

@ssirowy
Copy link
Contributor

ssirowy commented Nov 18, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants