Blueprint removes <title> from app/index.html upon install for FastBoot #177
Conversation
| } | ||
| ); | ||
|
|
||
| const titleMatches = contents.match(/<title>(.*)<\/title>/i); |
There was a problem hiding this comment.
While this works, maybe there are some other well formed ways to do edits like this from blueprints?
There was a problem hiding this comment.
I'm not aware of any, but @rwjblue might be more familiar.
There was a problem hiding this comment.
In theory, we could use ember-template-recast here but that has issues with <DOCTYPE.
I think (since <title> doesn't allow nesting, and the location is stable/knowable) that this is fine...
|
#178 - this should fix the private router access caused linter failure. |
raido
force-pushed
the
remove-title-element-upon-install
branch
from
0561c2b to
4aa0984
Compare
|
It is rebased and CI should be fine now. Should we try to add some tests for updated blueprint with https://github.com/ember-cli/ember-cli-blueprint-test-helpers or not worth it for now? |
|
Probably not worth it for now, if we have to revise this with something a bit more complicated then can revisit adding tests. |
Make blueprint remove title element from index.html if ember-cli-fastboot is present.
Closes #174.