Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Update ember-cli-head to v1.0.0 #162

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

jrjohnson
Copy link
Contributor

This is breaking as it drops support for Node < 10 I didn't make the changes to drop Node 8 here because they are best done with an update to ember-cli and I wasn't able to get that updated successfully myself.

@knownasilya
Copy link
Contributor

Thanks for this! I'm going to leave this open and do a deprecation of {{title}} first and release that as a patch before merging any breaking changes.

@chancancode
Copy link

This will resolve the deprecation on beta

@alexlafroscia
Copy link

@knownasilya has enough time passed to merge this and cut a 6.0.0 that includes this upgrade?

With Ember 3.20 going live, I'm getting a build-time warning about the private -in-element helper used by ember-cli-head, which is in our build pipeline because of ember-page-title.

@knownasilya knownasilya merged commit 4f249a9 into ember-cli:master Aug 3, 2020
@knownasilya
Copy link
Contributor

Will release this week.

@jrjohnson jrjohnson deleted the update-ember-cli-head branch August 3, 2020 18:40
@gilest
Copy link

gilest commented Sep 28, 2020

Please release soon 👋 ❤️

@knownasilya
Copy link
Contributor

We've actually removed the dependency. A new major version will be released soon. A few small things left to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants