Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer not exported from DefinitelyTyped @ember/runloop package #1063

Closed
charlesfries opened this issue Jan 23, 2024 · 2 comments
Closed

Timer not exported from DefinitelyTyped @ember/runloop package #1063

charlesfries opened this issue Jan 23, 2024 · 2 comments

Comments

@charlesfries
Copy link

#961 switched EmberRunTimer imported from @ember/runloop/types to Timer imported from @ember/runloop.

import { type Timer, cancel, next } from '@ember/runloop';

It seems that the DefinitelyTyped @ember/runloop package does not export this Timer interface.

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/ember__runloop/index.d.ts

Resulting in this error:

image

Unfortunately I am unable to switch to the internal Ember types because EmberData is not yet compatible with those types AFAIK.

My question is:

  1. Should this addon be compatible with the older DT types?
  2. If so, is this something that should be fixed here or in DT? If it's the latter feel free to close this issue, I will open a new one in DT.
@jelhan
Copy link
Collaborator

jelhan commented Jan 24, 2024

I asked the same question regarding another addon in Ember Discord. Got the recommendation that it should be fixed in DefinetlyTyped.

@charlesfries
Copy link
Author

Fixed in @types/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants