Complete AMD module extraction (tested with ember-cli) #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielspaniel
added a commit
that referenced
this pull request
Dec 4, 2014
Complete AMD module extraction (tested with ember-cli)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it turns out that my previous pull request works for AMD and commonJS modules, but doesn't work for ember-cli modules. 😬
This pull request changes the way the factory-guy module is defined, and generates a file into dist/amd/factory-guy.js that returns the
FactoryGuyvariable as the default value. It's tested with ember-cli, and I'll be sending a pull request to ember-cli-data-factory-guy shortly to use the newest version of FactoryGuy.Thanks!