adds $.mockjax.clear() to the mixin's teardown method. #30

yratanov · 2014-11-01T04:59:42Z

I believe it is expected behavior by user (at least it was expected by me) that library clean up after itself. It is especially important in tests to keep them isolated.
tests clean up. avoid of using third-party libraries' code in the repo. Every dependency should be resolved using bower/npm.
using same mockjax version in tests as in dist.

* I believe it is expected behavior by user (at least it was expected by me) that library clean after work. It is especially important in tests to keep them isolated. * tests clean up. avoid of using third-party libraries' code in the repo. Every dependency should be resolved using bower/npm. * using same mockjax version in tests as in dist.

adds $.mockjax.clear() to the mixin's teardown method.

danielspaniel · 2014-11-01T07:05:00Z

@yratanov .. thanks for that by the way .. you were right about all 3 points. :)

danielspaniel added a commit that referenced this pull request Nov 1, 2014

Merge pull request #30 from yratanov/master

aadada6

adds $.mockjax.clear() to the mixin's teardown method.

danielspaniel merged commit aadada6 into adopted-ember-addons:master Nov 1, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds $.mockjax.clear() to the mixin's teardown method. #30

adds $.mockjax.clear() to the mixin's teardown method. #30

yratanov commented Nov 1, 2014

danielspaniel commented Nov 1, 2014

adds $.mockjax.clear() to the mixin's teardown method. #30

adds $.mockjax.clear() to the mixin's teardown method. #30

Conversation

yratanov commented Nov 1, 2014

danielspaniel commented Nov 1, 2014