Misc. typo fixes #265
Merged
Misc. typo fixes #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorcan
force-pushed
the
lorcan/tiny-typo-fixes
branch
from
96d1782 to
3eafc22
Compare
lorcan
commented
Dec 12, 2016
| @@ -189,7 +189,7 @@ class ModelDefinition { | |||
| fixture[attribute] = fixture[attribute].call(this, fixture); | |||
| } | |||
|
|
|||
| addObjectAtribute(fixture, attribute) { | |||
| addObjectAttribute(fixture, attribute) { | |||
There was a problem hiding this comment.
This is the only change I'm worried about - is there any possible callers of this function apart from earlier in this file (L170)?
|
No at all .. pedantic is good in these cases, because it makes everything more sharp. Especially in documentation, things should be as close to perfect as possible. Thanks for the efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across a couple of typos in the Readme and decided to run a spell check. Hope you don't mind and I'm not being too pedantic ;-)