Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix the test suite #534

Merged
merged 3 commits into from
Sep 6, 2017

Conversation

Dhaulagiri
Copy link
Contributor

I'm not exactly sure what changed to make the test suite so unhappy, but in general ember-try seemed to be having problems installing ember data correctly so I updated a bunch of the failing scenarios to get them to work.

Of particular note:

  • It might make sense to remove some of the older scenarios at some point
  • I could not get the Ember 2.3 scenario working so I removed it. Let me know if you feel strongly about keeping it and I can try again.
  • The ember-release scenario was breaking because it couldn't run with ember data 2.14. I think that is related to this ember data issue so I made that scenario run with ember data 2.13 for now.

@offirgolan
Copy link
Collaborator

@Dhaulagiri this is fantastic! Thank you so much for taking the time to fix this!

I 100% agree with you that some of these scenarios can be removed. What are your thoughts about the following:

env:
   - EMBER_TRY_SCENARIO=default
   - EMBER_TRY_SCENARIO=ember-1.13
   - EMBER_TRY_SCENARIO=ember-lts-2.4
   - EMBER_TRY_SCENARIO=ember-lts-2.8
   - EMBER_TRY_SCENARIO=ember-2.12
   - EMBER_TRY_SCENARIO=ember-release
   - EMBER_TRY_SCENARIO=ember-beta
   - EMBER_TRY_SCENARIO=ember-canary

@Dhaulagiri
Copy link
Contributor Author

That sounds good to me. It seems like 1.13 could be dropped as well at some point, but as long as 1.13 support isn't a hindrance it seem worth keeping around for now.

@offirgolan
Copy link
Collaborator

Agreed. I plan to start dropping support for Ember < 2.0 when 3.0 is released.

@Dhaulagiri
Copy link
Contributor Author

@offirgolan updated the scenarios based on your suggestion

@offirgolan
Copy link
Collaborator

@Dhaulagiri thank you! 😸

@offirgolan offirgolan merged commit f9d4a75 into adopted-ember-addons:master Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants