-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
performance #74
Comments
Hey Stef, I've added you to this repo as well. |
@stefanpenner only watching |
Any progress on this issue @stefanpenner? |
Do you have any agreement on what an API would look like? I'm keen to help implement this as this bottleneck is adding 30 seconds to my cold starts (when using npm linked modules) and 2-3 seconds to each rebuild. |
I hacked together an addon that passes a tree containing only https://github.com/dmfenton/ember-cli-prune-style-tree |
@dmfenton @stefanpenner would be the best person to ask about this. Stef any thoughts on this? Is there someone else that would be good to speak to about this? |
Putting this here for discussion as it can help with adopted-ember-addons#74. This PR adds a new option `onlyIncluded` which allows the user to prune the style tree down to just app/styles and anything in the `includePaths` array. This helps performance because the broccoli-caching-writer no longer has to stat everything in the addon trees (via walk-sync). The speedup is especially pronounced when using linked modules because those trees can get very large.
Are there any updates on this one? ember-cli-prune-style-tree doesn't seem to be a drop-in solution for us. |
@stefanpenner Any news? |
Thanks to @dmfenton's addon our rebuild times were reduced by 2/3 (from about 7 seconds to about 2). This should be part of ember-cli-sass! |
Sounds interesting. Can you send a link and we'll have a look.
--
Simon Wade - Chief Technical Officer
*jtribe* - love your apps
13/243 Collins Street, Melbourne VIC 3000
[email protected] | +61 422 777 262 <+61422777262> | http://jtribe.com.au
|
It's the one he posted above: I'm not sure if it works for every use case but we haven't had any problems with it. |
We just had problems with compiling in-repo-addon styles using the app's outputPaths option. After some debugging I remembered installing above mentioned ember-cli-prune-style-tree addon. It only allows styles in the app directory to be compiled. So beware. If other people should run into the same problem here is what the error message looks like:
|
There is an easy way to get much better performance. Currently, everything in bower_components/vendor and app are considered when determining if a rebuild is needed or not.
Now this means stuff "magically" works, but this means as an app and vendor grow. Copious time is spent merely figuring out if some input file changed or not.
We have several options, likely worth exploring. Most affective would be:
app/styles
by defaultAn example API could be:
Another thing, would be to add matcher, to only both detecting specific file types. This will require some fixes to our change detection, but again may yield a good win.
Unfortunately, I am unclear if such a matcher exists. Would it be possible for us to only watch files with the following extensions?
.css
.scss
.sass
?Some recent micro-optimizations that yield a nice boost: (reducing costs of stats + crawls by 2x), but ^ would be a substantial win in many cases.
part 1: adopted-ember-addons/broccoli-sass-source-maps#5
part 2: ember-cli/broccoli-caching-writer#58
The text was updated successfully, but these errors were encountered: