Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with Embroider #243

Open
EWhite613 opened this issue Jun 27, 2023 · 5 comments
Open

Does not work with Embroider #243

EWhite613 opened this issue Jun 27, 2023 · 5 comments

Comments

@EWhite613
Copy link

As soon as add Embroider to app get the following error:

Sass Syntax Error (SassCompiler) in /var/folders/pp/c2t4mbcx5h7bcds74ycn_pn40000gq/T/broccoli-69612Xlii22B2hH23/out-0008-funnel/addon.scss:3:1

Error: File to import not found or unreadable: ../pods/components/context-panel/styles.
        on line 3 of ../../../../var/folders/pp/c2t4mbcx5h7bcds74ycn_pn40000gq/T/broccoli-69612Xlii22B2hH23/out-0008-funnel/addon.scss
>> @import '../pods/components/context-panel/styles';

Note this error comes from an Addon the App consumes, which uses ember-cli.

@EWhite613
Copy link
Author

EWhite613 commented Jun 27, 2023

I believe I can use the webpack sass-loader in my App. But atm not sure there's a way forward with consuming an addon that uses ember-cli-sass. Some discussion on Ember discord others may find useful

@amk221
Copy link

amk221 commented Jan 19, 2024

What's the situation re embrdoier? When I ask Glime, it suggests not using this addon and instead using a Webpack plugin, is that right?

@EWhite613
Copy link
Author

EWhite613 commented Jan 19, 2024

@amk221 Currently I don't have it working in my setup (but I perhaps am doing some more abnormal things like importing from node_modules). I plan to try experimenting with moving to postcss and using https://github.com/csstools/postcss-sass. I have it locally, just need to see if my setup converted to that will still not work with Embroider or what.

@bendemboski does however use ember-cli-sass in Embroider (discord about this). So it may be some use case I have that does not work

@EWhite613
Copy link
Author

@amk221 If starting ecosystem from scratch I don't think most people advise using ember-cli-sass anymore (I wouldn't for sure)

@amk221
Copy link

amk221 commented Jan 19, 2024

Thanks @EWhite613, not starting from scratch, updating a 10 year old project that already uses ember-cli-sass :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants