Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query-builder): add support for columns for with and withRecursive #826

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Conversation

Melchyore
Copy link
Contributor

@Melchyore Melchyore commented Apr 24, 2022

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

Add support for columns to Query Builder with and withRecursive methods. Knex already supports them but it was not possible to pass columns using Lucid QB methods.

If this PR is merged, I will add the corresponding docs.

@thetutlage thetutlage added the Type: Enhancement Improving an existing feature label Apr 27, 2022
@thetutlage thetutlage merged commit 1518dc6 into adonisjs:develop Apr 27, 2022
@thetutlage
Copy link
Member

Thanks for the PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants