Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu shows focus border on click in safari #908

Closed
adixon-adobe opened this issue Sep 28, 2020 · 2 comments · Fixed by #905
Closed

Menu shows focus border on click in safari #908

adixon-adobe opened this issue Sep 28, 2020 · 2 comments · Fixed by #905
Labels
Browser: Safari Component: Action Menu Component: Menu Component: Picker

Comments

@adixon-adobe
Copy link
Collaborator

Expected Behaviour

A menu doesn't show a blue focus border on click.

Actual Behaviour

On safari it does. Easy to repro in the doc pages for Menu, Action Menu, & Dropdown

Steps to Reproduce

  1. Go to https://opensource.adobe.com/spectrum-web-components/components/menu
  2. Click on a menu

Screenshots

Screen Shot 2020-09-28 at 11 16 28 AM
@Westbrook
Copy link
Contributor

We're making some adjustments to this element in #905, let me take a look and see if it makes sense to address this there.

@Westbrook
Copy link
Contributor

Looks like this is working in https://5f6e5921adb59e0095ccb7c2--spectrum-web-components.netlify.app/ the preview for #905. Can you confirm you're seeing the same?

@Westbrook Westbrook mentioned this issue Sep 28, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Browser: Safari Component: Action Menu Component: Menu Component: Picker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dropdown): improve accessibility adobe/spectrum-web-components
2 participants
@Westbrook @adixon-adobe