Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overlays to trap the tab order. #709

Closed
Westbrook opened this issue May 26, 2020 · 0 comments · Fixed by #728
Closed

Allow overlays to trap the tab order. #709

Westbrook opened this issue May 26, 2020 · 0 comments · Fixed by #728
Labels
a11y Issues related to accessibility Component: Dialog Component: Overlay

Comments

@Westbrook
Copy link
Contributor

Westbrook commented May 26, 2020 •
edited
Loading

As per https://codepen.io/samthor/live/b459e77f8dc7fe8a32925866bf4e0628 we could leverage shadow DOM to implement tab trapping of overlaid content with a relatively low lift. Questions we'd want to have answered:

  • Is trapping off of body as is done in the example to invasive?
  • When should we trap? For instance, the click-content of an overlay-trigger likely wants for trapping all the time, but the sp-dropdown element does not.
  • Should trapping be an explicit part of the Overlay API or implicit to an overlay type?

related #710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a11y Issues related to accessibility Component: Dialog Component: Overlay
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Manage tab order and focus placement with Overlay adobe/spectrum-web-components
1 participant
@Westbrook