Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: sp-dialog-wrapper to render sp-alert-dialog, at least the error variant #4935

Open
1 task done
lehelen19 opened this issue Nov 12, 2024 · 0 comments · May be fixed by #4909
Open
1 task done

[Feat]: sp-dialog-wrapper to render sp-alert-dialog, at least the error variant #4935

lehelen19 opened this issue Nov 12, 2024 · 0 comments · May be fixed by #4909
Labels
Component: Dialog enhancement New feature or request WIP

Comments

@lehelen19
Copy link
Contributor

lehelen19 commented Nov 12, 2024 •
edited
Loading

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-dialog-wrapper

Description of the requested feature

Since <sp-dialog> with the error attribute will be removed in the future, we should support the transition from <sp-dialog> to <sp-alert-dialog> in the cases that <sp-dialog-wrapper> should render the error variant of the <sp-dialog>.

Right now, if we have <sp-dialog-wrapper error></sp-dialog-wrapper> and leverage its other properties, we are not as easily able to transition to using an <sp-alert-dialog variant="error"></sp-alert-dialog>.

Mockups or screenshots

No response

Implementation notes or ideas

Draft PR with example: https://github.com/adobe/spectrum-web-components/pull/4909/files
@lehelen19 lehelen19 added enhancement New feature or request needs jira ticket triage An issue needing triage labels Nov 12, 2024
@najikahalsema najikahalsema linked a pull request Nov 19, 2024 that will close this issue
Draft
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Dialog enhancement New feature or request WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dialog): support sp-alert-dialog in sp-dialog-wrapper lehelen19/spectrum-web-components
2 participants
@najikahalsema @lehelen19