bug(checkbox): added missing readonly prop value #3859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajdeepc
changed the title
Tachometer resultsChromecard permalink
checkbox permalink
switch permalink
table permalink
Firefoxcard permalink
checkbox permalink
switch permalink
table permalink
|
Westbrook
reviewed
Dec 8, 2023
|
Related, looks like Spectrum CSS moves the |
added 2 commits
December 11, 2023 13:23
Westbrook
reviewed
Dec 11, 2023
Westbrook
reviewed
Dec 11, 2023
… into bug/checkbox
Westbrook
reviewed
Dec 13, 2023
Yes should be added now. |
1 task
Rajdeepc
changed the title
Westbrook
approved these changes
Dec 14, 2023
najikahalsema
pushed a commit
that referenced
this pull request
Dec 19, 2023
* chore(checkbox): added missing prop value * chore(checkbox): updated disabled on readonly * chore(checkbox): update golden image cache * chore(checkbox): allowing support for both setting and removing readonly * chore(checkbox): added the disabled proprety directly to the input * chore(checkbox): updated golden image cache * chore(checkbox): added test for readonly typing --------- Co-authored-by: Rajdeep Chandra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added missing readonly prop value
Related issue(s)
Motivation and context
Showing an error on readonly prop in
CheckBoxswc-react component.How has this been tested?
yarn linkat packages/checkbox in SWCand
yarn link "@spectrum-web-components/checkbox"Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.