fix(menu): allow change events to be direct
#3689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westbrook
requested review from
Rajdeepc,
blunteshwar,
najikahalsema and
TarunAdobe
Tachometer resultsChromeaction-menu permalink
menu permalink
picker permalink
split-button permalink
Firefoxaction-menu permalink
menu permalink
picker permalink
split-button permalink
|
There was a problem hiding this comment.
Is this functionality something that is expected or standard to a menu like this, or is this something we'd like to optionally toggle? I can imagine as an end user if I had some unexpected text copied in my clipboard from a menu item I messed with, I would be annoyed.
|
Yes, randomly copying stuff into people's clipboard would be weird! However, all of the copy workflows are part of the demos herein, not the custom elements that are distributed themselves. 😅 |
|
Oh, duh. My brain didn't register this was only in the stories. |
najikahalsema
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove an asynchronous break in the call stack between
clickandchangeso thatnavigator.clipboard.copyText()can be safely called during thechangeevent.Test this.
Demonstrate it in a handful of stories.
Related issue(s)
How has this been tested?
value(or text in most cases) has been copied to the clipboardvalue(or text in most cases) has been copied to the clipboardTypes of changes
Checklist