fix(number-field): correct composition entry of multi-byte numbers #3610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunterloftis
force-pushed
the
number-field-composition-merge
branch
from
33126f5 to
f407dd9
Compare
Tachometer resultsChromenumber-field permalink
search permalink
slider permalink
textfield permalink
Firefoxnumber-field permalink
search permalink
slider permalink
textfield permalink
|
Westbrook
force-pushed
the
number-field-composition-merge
branch
from
f407dd9 to
2875fca
Compare
najikahalsema
approved these changes
Aug 30, 2023
Westbrook
reviewed
Aug 30, 2023
| protected handleCompositionEnd(): void { | ||
| this.isComposing = false; | ||
| requestAnimationFrame(() => { | ||
| this.inputElement.dispatchEvent( |
There was a problem hiding this comment.
I wish I remembered why I did this in the rAF(). It's the only part that seems clearly brittle/directly working to not step on the OS's toes, which means easy to break.
Westbrook
changed the title
Westbrook
changed the title
blunteshwar
pushed a commit
that referenced
this pull request
Sep 12, 2023
Co-authored-by: Westbrook Johnson <[email protected]>
This was referenced Sep 20, 2023
|
@hunterloftis @Westbrook @najikahalsema Can you please review the latest tests using this fix in https://jira.corp.adobe.com/browse/CCEX-47632 ? It sounds like the behavior is better (for the most part, there's no more double entry) but there is still incorrect behavior depending on browser, OS, and language. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current implementation: Intercepts IME-based keystrokes and replaces them with their single-byte cousin.
This change: Accepts all keystrokes until the component is blurred (loses focus), then converts all IME-based characters into their single-byte cousins.
Related issue(s)
Motivation and context
Fix Number Field issues with certain Input Method Editor (IME) input types.
How has this been tested?
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.