Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: We need a way to disable hover state for all spectrum buttons on mobile devices #2598

Closed
1 task done
monkeyjabs opened this issue Sep 19, 2022 · 6 comments · Fixed by #4006
Closed
1 task done

Comments

@monkeyjabs
Copy link
Contributor

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

ProjectX

Expected behavior

There's a lingering hover effect on the mobile browser with button-related components such as sp-menu-item, sp-action-button, and sp-button; this is causing confusion for users.

Actual behavior

SWC should have a way to detect on mobile devices and disabled the hover effects

Screenshots

PixelSnap 2022-09-19 at 09 28 57

RPReplay_Final1663353021.MP4

What browsers are you seeing the problem in?

Safari

How can we reproduce this issue?

  1. Go to ProjectX
  2. Click on Plus menu
  3. Scroll to through the list of menu items
  4. Observe there are some items with linger hover states

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

@monkeyjabs monkeyjabs added bug Something isn't working triage An issue needing triage labels Sep 19, 2022
@Westbrook
Copy link
Contributor

Thanks @monkeyjabs! We just merged #2597, would you be able to checkout https://main--spectrum-web-components.netlify.app/ and let us know how if you're seeing this situation lessened?

@monkeyjabs
Copy link
Contributor Author

@Westbrook It looks like this the fix in #2597 did improved a bit but I'm still seeing issue.

I tried with the sp-menu component here from: https://main--spectrum-web-components.netlify.app/components/menu/#managing-a-selection

If I tap on the menu item and scroll I sell see the hover state remain.
IMG_2272

@najikahalsema
Copy link
Collaborator

To do: ask Spectrum css about hover state behaviour.

@Westbrook
Copy link
Contributor

We've upstreamed an issue to Spectrum CSS to wrap :hover styles in @supports (hover: hover) as part of the work that would go into this...

@monkeyjabs
Copy link
Contributor Author

@Westbrook is there a way to track that upstream issue?

@Westbrook
Copy link
Contributor

You can track here: https://jira.corp.adobe.com/projects/CSS/issues/CSS-289

We'll be discussing https://github.com/saulhardman/postcss-hover-media-feature after the holidays and whether/were's the right place to inject that in the overall Spectrum universe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants