Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: when sp-picker is open on mobile, screen is scrollable #2536

Closed
1 task done
cdvu1 opened this issue Aug 23, 2022 · 2 comments
Closed
1 task done

[Bug]: when sp-picker is open on mobile, screen is scrollable #2536

cdvu1 opened this issue Aug 23, 2022 · 2 comments
Labels
bug Something isn't working Component: Overlay Component: Picker Mobile Post overlay API Review after Overlay V2 Ships

Comments

@cdvu1
Copy link
Collaborator

cdvu1 commented Aug 23, 2022

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-picker

Expected behavior

When sp-picker is open in mobile, scrolling should be blocked or the menu should be dismissed.

Actual behavior

When the sp-picker menu is open on mobile, and I am able to scroll around while the menu is still open.

Screenshots

Video attached in this Google Drive link:
https://drive.google.com/file/d/1ItsjsvXjiWJTtwYcrnI5Fhg0YSODwdgp/view?usp=sharing

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to Lightroom Academy article
  2. Make sure you are on a mobile device
  3. Use your finger to scroll up and down around where the menu area is and you will see the screen is scrollable while sp-picker is still displayed.

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

@cdvu1 cdvu1 added bug Something isn't working triage An issue needing triage labels Aug 23, 2022
@Westbrook Westbrook added the Post overlay API Review after Overlay V2 Ships label Jul 20, 2023
@najikahalsema najikahalsema removed the triage An issue needing triage label Oct 5, 2023
@Westbrook
Copy link
Contributor

Want to make sure there was visibility into this approach to this situation: #3849 (comment)

@Westbrook
Copy link
Contributor

Dupe of #3849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Component: Overlay Component: Picker Mobile Post overlay API Review after Overlay V2 Ships
Projects
None yet
Development

No branches or pull requests

3 participants