Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(textfield): add support for setSelectionRange #2070

Merged
merged 3 commits into from
Jan 24, 2022
Merged

Conversation

joekukish
Copy link
Collaborator

@joekukish joekukish commented Jan 21, 2022

Description

Related issue(s)

Motivation and context

How has this been tested?

  • Test case 1
    1. Go here
    2. Do this
  • Test case 2
    1. Go here
    2. Do this

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@github-actions
Copy link

@github-actions
Copy link

github-actions bot commented Jan 21, 2022

Tachometer results

Chrome

number-field permalink

Version Bytes Avg Time vs remote vs branch
npm latest 675 kB 180.49ms - 181.78ms - unsure 🔍
-0% - +1%
-0.17ms - +1.42ms
branch 675 kB 180.04ms - 180.97ms unsure 🔍
-1% - +0%
-1.42ms - +0.17ms
-

search permalink

Version Bytes Avg Time vs remote vs branch
npm latest 490 kB 93.56ms - 94.64ms - unsure 🔍
-1% - +1%
-0.49ms - +0.71ms
branch 490 kB 93.72ms - 94.24ms unsure 🔍
-1% - +1%
-0.71ms - +0.49ms
-

slider permalink

Version Bytes Avg Time vs remote vs branch
npm latest 484 kB 143.74ms - 144.68ms - faster ✔
0% - 1%
0.59ms - 2.16ms
branch 484 kB 144.95ms - 146.21ms slower ❌
0% - 2%
0.59ms - 2.16ms
-

textfield permalink

Version Bytes Avg Time vs remote vs branch
npm latest 434 kB 58.98ms - 59.31ms - unsure 🔍
-0% - +1%
-0.28ms - +0.30ms
branch 434 kB 58.90ms - 59.38ms unsure 🔍
-1% - +0%
-0.30ms - +0.28ms
-
Firefox

number-field permalink

Version Bytes Avg Time vs remote vs branch
npm latest 675 kB 574.17ms - 594.59ms - unsure 🔍
-2% - +3%
-8.90ms - +18.42ms
branch 675 kB 570.54ms - 588.70ms unsure 🔍
-3% - +2%
-18.42ms - +8.90ms
-

search permalink

Version Bytes Avg Time vs remote vs branch
npm latest 490 kB 235.02ms - 244.02ms - unsure 🔍
-4% - +2%
-10.70ms - +4.94ms
branch 490 kB 236.00ms - 248.80ms unsure 🔍
-2% - +4%
-4.94ms - +10.70ms
-

slider permalink

Version Bytes Avg Time vs remote vs branch
npm latest 484 kB 509.92ms - 528.72ms - unsure 🔍
-2% - +3%
-10.76ms - +14.60ms
branch 484 kB 508.89ms - 525.91ms unsure 🔍
-3% - +2%
-14.60ms - +10.76ms
-

textfield permalink

Version Bytes Avg Time vs remote vs branch
npm latest 434 kB 162.83ms - 174.25ms - unsure 🔍
-2% - +6%
-2.98ms - +10.18ms
branch 434 kB 161.69ms - 168.19ms unsure 🔍
-6% - +2%
-10.18ms - +2.98ms
-

@joekukish joekukish requested a review from Westbrook January 21, 2022 23:36
@Westbrook Westbrook merged commit dd17ba0 into main Jan 24, 2022
@Westbrook Westbrook deleted the issue/2069 branch January 24, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Textfield: add support for setSelectionRange
2 participants